NyanLinnPai/famous-ly4-ev
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Generalize per-vehicle-option booking rules to Front Seat too

Browse Source 
Front Seat previously had a hardcoded max-per-booking check with no enable
toggle; now every Vehicle Option (front_seat/back_seat/whole_vehicle) gets
the same config-driven pair — an on/off toggle and a max passenger_count —
surfaced via new BOOKING_*_ENABLED/BOOKING_*_MAX_PER_BOOKING env vars,
editable from ManageAppSettings, and exposed on route pricing as
max_per_booking.
This commit is contained in:
Nyan Lin Paing
2026-08-30 15:45:27 +07:00
parent 914b7f97f3
commit bebcab88fa
11 changed files with 175 additions and 97 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app-modules/booking/tests/Feature/BookingCreateApiTest.php
+31 -1
View File
@@ -97,7 +97,37 @@ test('front-seat-limit rejection surfaces as 422', function () {
['vehicle_option' => 'front_seat', 'passenger_count' => 2],
]))
->assertStatus(422)
->assertJsonPath('message', 'Front seat request [2] exceeds the max of [1] per booking.');
->assertJsonPath('message', 'Vehicle option [front_seat] passenger count [2] exceeds the max of [1] per booking.');
expect(Booking::count())->toBe(0);
});
test('back-seat-limit rejection surfaces as 422', function () {
config(['booking.back_seat_max_per_booking' => 1]);
[$route, $timeSlot] = bookableRouteAndSlot([[VehicleOption::BackSeat, '9000.00']]);
$this->withHeader('Authorization', "Bearer {$this->token}")
->postJson('/api/v1/bookings', bookingPayload($route, $timeSlot, [
['vehicle_option' => 'back_seat', 'passenger_count' => 2],
]))
->assertStatus(422)
->assertJsonPath('message', 'Vehicle option [back_seat] passenger count [2] exceeds the max of [1] per booking.');
expect(Booking::count())->toBe(0);
});
test('whole-vehicle-limit rejection surfaces as 422', function () {
config(['booking.whole_vehicle_max_per_booking' => 1]);
[$route, $timeSlot] = bookableRouteAndSlot([[VehicleOption::WholeVehicle, '30000.00']]);
$this->withHeader('Authorization', "Bearer {$this->token}")
->postJson('/api/v1/bookings', bookingPayload($route, $timeSlot, [
['vehicle_option' => 'whole_vehicle', 'passenger_count' => 2],
]))
->assertStatus(422)
->assertJsonPath('message', 'Vehicle option [whole_vehicle] passenger count [2] exceeds the max of [1] per booking.');
expect(Booking::count())->toBe(0);
});
app-modules/booking/tests/Unit/BookingServiceTest.php
+41 -29
View File
@@ -30,40 +30,52 @@ test('front seat and back seat can be selected together in one booking', functio
]))->not->toThrow(InvalidVehicleSelectionException::class);
});
test('requesting more front seats than the configured max is rejected', function () {
test('requesting more passengers than the configured max is rejected', function (VehicleOption $option) {
config(["booking.{$option->value}_max_per_booking" => 1]);
$service = new BookingService;
expect(fn () => $service->validateSelections([new VehicleSelectionData($option, 2)]))
->toThrow(InvalidVehicleSelectionException::class);
})->with([
'front_seat' => [VehicleOption::FrontSeat],
'back_seat' => [VehicleOption::BackSeat],
'whole_vehicle' => [VehicleOption::WholeVehicle],
]);
test('requesting passengers up to the configured max passes', function (VehicleOption $option) {
config(["booking.{$option->value}_max_per_booking" => 2]);
$service = new BookingService;
expect(fn () => $service->validateSelections([new VehicleSelectionData($option, 2)]))
->not->toThrow(InvalidVehicleSelectionException::class);
})->with([
'front_seat' => [VehicleOption::FrontSeat],
'back_seat' => [VehicleOption::BackSeat],
'whole_vehicle' => [VehicleOption::WholeVehicle],
]);
test('an option is rejected when disabled via config', function (VehicleOption $option) {
config(["booking.{$option->value}_enabled" => false]);
$service = new BookingService;
expect(fn () => $service->validateSelections([new VehicleSelectionData($option)]))
->toThrow(InvalidVehicleSelectionException::class, "Vehicle option [{$option->value}] is not currently available for booking.");
})->with([
'front_seat' => [VehicleOption::FrontSeat],
'back_seat' => [VehicleOption::BackSeat],
'whole_vehicle' => [VehicleOption::WholeVehicle],
]);
test('exceeding the max produces the expected message', function () {
config(['booking.front_seat_max_per_booking' => 1]);
$service = new BookingService;
expect(fn () => $service->validateSelections([new VehicleSelectionData(VehicleOption::FrontSeat, 2)]))
->toThrow(InvalidVehicleSelectionException::class);
});
test('requesting front seats up to the configured max passes', function () {
config(['booking.front_seat_max_per_booking' => 2]);
$service = new BookingService;
expect(fn () => $service->validateSelections([new VehicleSelectionData(VehicleOption::FrontSeat, 2)]))
->not->toThrow(InvalidVehicleSelectionException::class);
});
test('back seat is rejected when disabled via config', function () {
config(['booking.back_seat_enabled' => false]);
$service = new BookingService;
expect(fn () => $service->validateSelections([new VehicleSelectionData(VehicleOption::BackSeat)]))
->toThrow(InvalidVehicleSelectionException::class);
});
test('whole vehicle is rejected when disabled via config', function () {
config(['booking.whole_vehicle_enabled' => false]);
$service = new BookingService;
expect(fn () => $service->validateSelections([new VehicleSelectionData(VehicleOption::WholeVehicle)]))
->toThrow(InvalidVehicleSelectionException::class);
->toThrow(InvalidVehicleSelectionException::class, 'Vehicle option [front_seat] passenger count [2] exceeds the max of [1] per booking.');
});
test('the same vehicle option cannot be selected twice in one booking', function () {