Nyan Lin Paing
fd3a195453
Access group (Filament):
- StaffResource: manage users with an admin-tier role, gated by manage_staff
- CustomerResource: read-only view of role-less users, gated by view_customers
- RoleResource: edit permissions per role (fixed role set), gated by manage_roles
- ManageAppSettings: tabbed General/Booking settings page that reads/writes
real .env keys via new EnvFileWriter (no parallel DB settings table, so
BookingService/config('booking.*') stay unchanged)
- Moved Access above Catalog in the nav group order
- New permissions: manage_staff, manage_roles, view_customers, manage_settings
Booking soft deletes:
- bookings.deleted_at + SoftDeletes on the Booking model
- BookingPolicy::delete (manage_bookings, cancelled/expired only) and
::restore (manage_bookings)
- DeleteBookingTableAction/RestoreBookingTableAction + TrashedFilter on
BookingsTable, using authorize() so the policy is enforced at call time,
not just cosmetically hidden
Refund crash fix:
- ProcessRefundAction passed a nullable $payment->booking into
RefundBookingAction's non-nullable Booking param — a soft-deleted
booking's payment reaching the refund picker was an uncaught TypeError.
Excluded such payments from the picker and added a defensive guard.
- Same unguarded $event->payment->booking / $event->refund->payment->booking
pattern fixed in the MarkBookingPaid/MarkBookingRefunded queued listeners.
289 tests passing.
41 lines
2.0 KiB
PHP
41 lines
2.0 KiB
PHP
<?php
|
|
|
|
use Modules\Booking\Enums\BookingStatus;
|
|
use Modules\Booking\Models\Booking;
|
|
use Modules\Payment\Enums\PaymentMethod;
|
|
use Modules\Payment\Enums\RefundStatus;
|
|
use Modules\Payment\Events\RefundProcessed;
|
|
use Modules\Payment\Listeners\MarkBookingRefunded;
|
|
use Modules\Payment\Models\Payment;
|
|
use Modules\Payment\Models\Refund;
|
|
|
|
test('flips a confirmed booking to cancelled', function () {
|
|
$booking = Booking::factory()->create(['status' => BookingStatus::Confirmed]);
|
|
$payment = Payment::factory()->completed()->create(['booking_id' => $booking->id, 'gateway' => PaymentMethod::KbzMiniApp]);
|
|
$refund = Refund::factory()->create(['payment_id' => $payment->id, 'status' => RefundStatus::Completed]);
|
|
|
|
(new MarkBookingRefunded)->handle(new RefundProcessed($refund));
|
|
|
|
expect($booking->refresh()->status)->toBe(BookingStatus::Cancelled);
|
|
});
|
|
|
|
test('does not touch a booking that already moved on for another reason', function () {
|
|
$booking = Booking::factory()->create(['status' => BookingStatus::Cancelled]);
|
|
$payment = Payment::factory()->completed()->create(['booking_id' => $booking->id, 'gateway' => PaymentMethod::KbzMiniApp]);
|
|
$refund = Refund::factory()->create(['payment_id' => $payment->id, 'status' => RefundStatus::Completed]);
|
|
|
|
(new MarkBookingRefunded)->handle(new RefundProcessed($refund));
|
|
|
|
expect($booking->refresh()->status)->toBe(BookingStatus::Cancelled);
|
|
});
|
|
|
|
test('does not crash if the booking was soft-deleted before this queued listener ran', function () {
|
|
$booking = Booking::factory()->create(['status' => BookingStatus::Confirmed]);
|
|
$payment = Payment::factory()->completed()->create(['booking_id' => $booking->id, 'gateway' => PaymentMethod::KbzMiniApp]);
|
|
$refund = Refund::factory()->create(['payment_id' => $payment->id, 'status' => RefundStatus::Completed]);
|
|
$booking->delete();
|
|
|
|
expect(fn () => (new MarkBookingRefunded)->handle(new RefundProcessed($refund->fresh())))
|
|
->not->toThrow(Throwable::class);
|
|
});
|