fd3a195453
Access group (Filament):
- StaffResource: manage users with an admin-tier role, gated by manage_staff
- CustomerResource: read-only view of role-less users, gated by view_customers
- RoleResource: edit permissions per role (fixed role set), gated by manage_roles
- ManageAppSettings: tabbed General/Booking settings page that reads/writes
real .env keys via new EnvFileWriter (no parallel DB settings table, so
BookingService/config('booking.*') stay unchanged)
- Moved Access above Catalog in the nav group order
- New permissions: manage_staff, manage_roles, view_customers, manage_settings
Booking soft deletes:
- bookings.deleted_at + SoftDeletes on the Booking model
- BookingPolicy::delete (manage_bookings, cancelled/expired only) and
::restore (manage_bookings)
- DeleteBookingTableAction/RestoreBookingTableAction + TrashedFilter on
BookingsTable, using authorize() so the policy is enforced at call time,
not just cosmetically hidden
Refund crash fix:
- ProcessRefundAction passed a nullable $payment->booking into
RefundBookingAction's non-nullable Booking param — a soft-deleted
booking's payment reaching the refund picker was an uncaught TypeError.
Excluded such payments from the picker and added a defensive guard.
- Same unguarded $event->payment->booking / $event->refund->payment->booking
pattern fixed in the MarkBookingPaid/MarkBookingRefunded queued listeners.
289 tests passing.
154 lines
5.7 KiB
PHP
154 lines
5.7 KiB
PHP
<?php
|
|
|
|
use App\Models\User;
|
|
use Livewire\Livewire;
|
|
use Modules\Booking\Enums\BookingStatus;
|
|
use Modules\Booking\Models\Booking;
|
|
use Modules\Payment\Contracts\PaymentGatewayInterface;
|
|
use Modules\Payment\Data\PaymentRequestData;
|
|
use Modules\Payment\Data\PaymentResultData;
|
|
use Modules\Payment\Data\RefundResultData;
|
|
use Modules\Payment\Enums\PaymentMethod;
|
|
use Modules\Payment\Enums\RefundStatus;
|
|
use Modules\Payment\Factories\PaymentGatewayFactory;
|
|
use Modules\Payment\Filament\Resources\Refunds\Pages\ListRefunds;
|
|
use Modules\Payment\Models\Payment;
|
|
use Modules\Payment\Models\Refund;
|
|
use Spatie\Permission\Models\Permission;
|
|
|
|
/**
|
|
* Never calls the real KBZ refund API in tests.
|
|
*/
|
|
class FakeFilamentRefundGateway implements PaymentGatewayInterface
|
|
{
|
|
public function initiate(PaymentRequestData $data): PaymentResultData
|
|
{
|
|
throw new RuntimeException('not needed for this test');
|
|
}
|
|
|
|
public function verify(string $gatewayTransactionId): PaymentResultData
|
|
{
|
|
throw new RuntimeException('not needed for this test');
|
|
}
|
|
|
|
public function refund(string $gatewayTransactionId, string $amount, string $reason): RefundResultData
|
|
{
|
|
return new RefundResultData(status: RefundStatus::Completed, gatewayRefundId: 'REFUND123', gatewayPayload: []);
|
|
}
|
|
|
|
public function handleWebhook(array $payload): PaymentResultData
|
|
{
|
|
throw new RuntimeException('not needed for this test');
|
|
}
|
|
}
|
|
|
|
beforeEach(function () {
|
|
foreach (['view_payments', 'process_refunds'] as $permission) {
|
|
Permission::findOrCreate($permission, 'web');
|
|
}
|
|
|
|
app(PaymentGatewayFactory::class)->register(PaymentMethod::KbzMiniApp, FakeFilamentRefundGateway::class);
|
|
});
|
|
|
|
test('a user with view_payments can list refunds', function () {
|
|
$viewer = User::factory()->create()->givePermissionTo('view_payments');
|
|
$this->actingAs($viewer);
|
|
|
|
$refunds = Refund::factory()->count(3)->create();
|
|
|
|
Livewire::test(ListRefunds::class)
|
|
->assertOk()
|
|
->assertCanSeeTableRecords($refunds);
|
|
});
|
|
|
|
test('the process action is hidden from a user without process_refunds', function () {
|
|
$viewer = User::factory()->create()->givePermissionTo('view_payments');
|
|
$this->actingAs($viewer);
|
|
|
|
Livewire::test(ListRefunds::class)
|
|
->assertActionHidden('process');
|
|
});
|
|
|
|
test('the process action is visible to a user with process_refunds', function () {
|
|
$admin = User::factory()->create()->givePermissionTo(['view_payments', 'process_refunds']);
|
|
$this->actingAs($admin);
|
|
|
|
Livewire::test(ListRefunds::class)
|
|
->assertActionVisible('process');
|
|
});
|
|
|
|
test('processing a refund via the action calls RefundBookingAction and cancels the booking', function () {
|
|
$admin = User::factory()->create()->givePermissionTo(['view_payments', 'process_refunds']);
|
|
$this->actingAs($admin);
|
|
|
|
$booking = Booking::factory()->create(['status' => BookingStatus::Confirmed, 'price' => 15000]);
|
|
$payment = Payment::factory()->completed()->create([
|
|
'booking_id' => $booking->id,
|
|
'gateway' => PaymentMethod::KbzMiniApp,
|
|
'amount' => 15000,
|
|
'gateway_transaction_id' => 'EVB-FILAMENT-REFUND-1',
|
|
]);
|
|
|
|
Livewire::test(ListRefunds::class)
|
|
->callAction('process', data: [
|
|
'payment_id' => $payment->id,
|
|
'amount' => 15000,
|
|
'reason' => 'customer requested cancellation',
|
|
])
|
|
->assertNotified();
|
|
|
|
expect($booking->refresh()->status)->toBe(BookingStatus::Cancelled)
|
|
->and(Refund::where('payment_id', $payment->id)->where('status', RefundStatus::Completed)->exists())->toBeTrue();
|
|
});
|
|
|
|
test('a non-completed payment is not offered in the process action\'s payment select', function () {
|
|
$admin = User::factory()->create()->givePermissionTo(['view_payments', 'process_refunds']);
|
|
$this->actingAs($admin);
|
|
|
|
$booking = Booking::factory()->create(['status' => BookingStatus::PendingPayment]);
|
|
$pendingPayment = Payment::factory()->create([
|
|
'booking_id' => $booking->id,
|
|
'gateway' => PaymentMethod::KbzMiniApp,
|
|
]);
|
|
|
|
// The Select itself rejects a value outside its "Completed only"
|
|
// options (domain.md §6) — RefundBookingAction's own guard against a
|
|
// non-confirmed booking is covered directly in RefundBookingActionTest.
|
|
Livewire::test(ListRefunds::class)
|
|
->callAction('process', data: [
|
|
'payment_id' => $pendingPayment->id,
|
|
'amount' => 1000,
|
|
'reason' => 'reason',
|
|
])
|
|
->assertHasFormErrors(['payment_id']);
|
|
|
|
expect(Refund::where('payment_id', $pendingPayment->id)->exists())->toBeFalse();
|
|
});
|
|
|
|
test('a payment whose booking has been soft-deleted is not offered in the process action\'s payment select', function () {
|
|
$admin = User::factory()->create()->givePermissionTo(['view_payments', 'process_refunds']);
|
|
$this->actingAs($admin);
|
|
|
|
$booking = Booking::factory()->create(['status' => BookingStatus::Cancelled, 'price' => 15000]);
|
|
$payment = Payment::factory()->completed()->create([
|
|
'booking_id' => $booking->id,
|
|
'gateway' => PaymentMethod::KbzMiniApp,
|
|
'amount' => 15000,
|
|
'gateway_transaction_id' => 'EVB-FILAMENT-DELETED-1',
|
|
]);
|
|
$booking->delete();
|
|
|
|
// Regression: a payment whose booking is gone must never crash the
|
|
// refund action (RefundBookingAction requires a non-null Booking) — it
|
|
// simply isn't offered as an option at all.
|
|
Livewire::test(ListRefunds::class)
|
|
->callAction('process', data: [
|
|
'payment_id' => $payment->id,
|
|
'amount' => 1000,
|
|
'reason' => 'reason',
|
|
])
|
|
->assertHasFormErrors(['payment_id']);
|
|
|
|
expect(Refund::where('payment_id', $payment->id)->exists())->toBeFalse();
|
|
});
|